Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and add padding in Sessions info banner #2695

Closed
wants to merge 1 commit into from

Conversation

use-tusk[bot]
Copy link
Contributor

@use-tusk use-tusk bot commented Sep 27, 2024

This PR addresses the following issues in the Sessions info banner for the Free plan:

  • Corrects the typos in the text content, changing 'Sessions are a Pro feature' to 'Sessions is a Pro feature' and 'September 27st' to 'September 27th'.
  • Adds a bottom margin (mb-2 class) to the InfoBox component to ensure it does not touch the demo below.

These changes improve the readability and visual spacing of the info banner on the Sessions page.


Browser testing result ✅

Success image

Step: [Verify] The info banner text reads 'Sessions is a Pro feature. In order to keep using them, you need to upgrade your plan before September 27th, 2024.'

The assertion states that the info banner text reads 'Sessions is a Pro feature. In order to keep using them, you need to upgrade your plan before September 27th, 2024.' The HTML content shows a

element with the name attribute 'Sessions is a Pro feature.' and a

element with the text 'Sessions is a Pro feature. In order to keep using them, you need to upgrade your plan before September 27th, 2024.' This matches the assertion exactly. The screenshot also confirms the presence of this text in the info banner at the top of the page.

Success Image 0-0


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review and I'll address it.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs to see more details.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:19am
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:19am
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:19am

@use-tusk use-tusk bot changed the title Tusk WIP - Free plan Sessions info banner typos and padding Fix typos and add padding in Sessions info banner Sep 27, 2024
@use-tusk use-tusk bot marked this pull request as ready for review September 27, 2024 01:25
@use-tusk use-tusk bot closed this Sep 27, 2024
@use-tusk use-tusk bot deleted the tusk-fix-sessions-typos-padding-092720240016 branch September 27, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants